Deprecate ModelManagerInterface collection-related methods #6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
deprecationCollection
branch
2 times, most recently
from
13fc225 to
4f564f4
Compare
VincentLanglet
commented
Aug 23, 2020
| @@ -45,27 +57,30 @@ public static function getSubscribedEvents() | |||
| public function onBind(FormEvent $event) | |||
| { | |||
| $collection = $event->getForm()->getData(); | |||
| \assert(null === $collection || $collection instanceof Collection); | |||
There was a problem hiding this comment.
I added null === $collection or phpstan report a useless if (!$collection) {.
But I dont know if this case is possible.
phansys
previously approved these changes
Aug 23, 2020
VincentLanglet
force-pushed
the
deprecationCollection
branch
from
4f564f4 to
29f480f
Compare
phansys
approved these changes
Aug 23, 2020
jordisala1991
approved these changes
Aug 23, 2020
franmomu
added a commit
to franmomu/SonataDoctrineMongoDBAdminBundle
that referenced
this pull request
Sep 10, 2020
These methods were deprecated in the interface in sonata-project/SonataAdminBundle#6312 and released in 3.75
franmomu
added a commit
to franmomu/SonataDoctrineMongoDBAdminBundle
that referenced
this pull request
Sep 10, 2020
These methods were deprecated in the interface in sonata-project/SonataAdminBundle#6312 and released in 3.75
franmomu
added a commit
to franmomu/SonataDoctrineMongoDBAdminBundle
that referenced
this pull request
Sep 12, 2020
These methods were deprecated in the interface in sonata-project/SonataAdminBundle#6312 and released in 3.75
franmomu
added a commit
to franmomu/SonataDoctrineMongoDBAdminBundle
that referenced
this pull request
Sep 12, 2020
These methods were deprecated in the interface in sonata-project/SonataAdminBundle#6312 and released in 3.75
franmomu
added a commit
to franmomu/SonataDoctrineMongoDBAdminBundle
that referenced
this pull request
Sep 12, 2020
These methods were deprecated in the interface in sonata-project/SonataAdminBundle#6312 and released in 3.75
greg0ire
pushed a commit
to sonata-project/SonataDoctrineMongoDBAdminBundle
that referenced
this pull request
Sep 12, 2020
These methods were deprecated in the interface in sonata-project/SonataAdminBundle#6312 and released in 3.75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because BC.
Closes #6024.
Changelog