Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation with SonataDoctrineBundle location #6264

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Aug 9, 2020

Subject

I am targeting this branch, because this is BC.

This is to prevent a deprecation on the tests, but also to avoid broken builds: #6263

I think something went wrong on last release of SonataDoctrineBundle

@jordisala1991 jordisala1991 requested a review from a team August 9, 2020 06:40
@jordisala1991
Copy link
Member Author

The problem is this file: https://github.com/sonata-project/sonata-doctrine-extensions/blob/1.x/src/Bridge/Symfony/Bundle/SonataDoctrineBundle.php

It is declaring a class named SonataDoctrineBundle, but it is also using a use of a SonataDoctrineBundle class, I think it makes everything crash.

Note that this PR is also needed to avoid deprecations, but we should resolve those errors too. (They happen on the other bridges too)

Copy link
Member

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to figure out want happened, could it be that in https://github.com/sonata-project/sonata-doctrine-extensions/blob/1.x/src/Bridge/Symfony/Bundle/SonataDoctrineBundle.php, is using:

use Sonata\Twig\Bridge\Symfony\SonataTwigBundle;

and then the declared class within this file is:

final class SonataTwigBundle extends Bundle

cc @phansys

@jordisala1991 jordisala1991 merged commit 47d1cea into sonata-project:3.x Aug 9, 2020
@jordisala1991 jordisala1991 deleted the hotfix/doctrine-extension branch August 9, 2020 06:54
@jordisala1991
Copy link
Member Author

I merge this one because we don't want broken builds here, but we should take a look at it

@franmomu
Copy link
Member

franmomu commented Aug 9, 2020

I'll make PRs, I guess adding an alias to the use is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants