Deprecate getParentFieldDescription from ModelManagerInterface #6234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Taking a look at the method
ModelManager::getParentFieldDescription()
from SonataDoctrineMongoDBAdminBundle (and the one in SonataDoctrineORMBundle), looks like they are not used anymore, in fact, the first parameter they receive ($parentAssociationMapping
) is an array and then there is this code (which would fail because of using anarray
as a key):This method was added in b0df44f, and the
$parentAssociationMapping
parameter back then was astring
. There was this call in theAbstractAdmin
class (previously known asAdmin
):Then in 789802d that call was replaced by calling to the
getParentFieldDescription
within theAdmin
class.There are maybe other uses of this method I haven't found, but looks like this method is not used.
I am targeting this branch, because these changes are BC.
Changelog