Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare support for block 4 #6220

Merged

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Jul 22, 2020

Subject

I am targeting this branch, because BC.

Similar to sonata-project/SonataDoctrineORMAdminBundle#1067

Related to #6212

Changelog

### Deprecated
- Passing `null` or an instance of `EngineInterface` as argument 2 when instantiating `Sonata\AdminBundle\Block\AdminListBlockService`, `Sonata\AdminBundle\Block\AdminSearchBlockService` or `Sonata\AdminBundle\Block\AbstractBlockService` 

jordisala1991
jordisala1991 previously approved these changes Jul 24, 2020
@VincentLanglet VincentLanglet requested a review from a team July 24, 2020 13:55
@VincentLanglet
Copy link
Member Author

@sonata-project/contributors Please review :)

This will help jordi PR #6212

src/Block/AdminListBlockService.php Outdated Show resolved Hide resolved
src/Block/AdminSearchBlockService.php Outdated Show resolved Hide resolved
src/Block/AdminStatsBlockService.php Outdated Show resolved Hide resolved
@VincentLanglet
Copy link
Member Author

Fixed @greg0ire. :)

@VincentLanglet VincentLanglet merged commit 4e250f9 into sonata-project:3.x Jul 28, 2020
@VincentLanglet VincentLanglet deleted the prepareBlock4Support branch July 28, 2020 11:25
@jordisala1991
Copy link
Member

I will work on a rebase of my PR today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants