Fix form one-to-many tabs translations #6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
previously approved these changes
Jul 3, 2020
phansys
reviewed
Jul 3, 2020
src/Resources/views/CRUD/Association/edit_one_to_many_inline_tabs.html.twig
Outdated
Show resolved
Hide resolved
core23
approved these changes
Jul 3, 2020
VincentLanglet
approved these changes
Jul 3, 2020
jordisala1991
approved these changes
Jul 3, 2020
|
Thank you @EmmanuelVella |
|
Thank you all ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Currently, the tabs in a one-to-many form are not correctly translated. The groups
nameis used, instead of thelabel(like in the other templates). This is wrong especially when using thetranslate_group_label: trueoption.This is BC because the
labelcontains thenameby default (see https://github.com/sonata-project/SonataAdminBundle/blob/3.x/src/Mapper/BaseGroupedMapper.php#L79).I am targeting this branch, because it's a BC bug fix.
Changelog
Before
After
