-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make twig/extra-bundle
optional
#6170
Make twig/extra-bundle
optional
#6170
Conversation
7ae1d78
to
ab77c6a
Compare
Could you please rebase your PR and fix merge conflicts? |
ab77c6a
to
781e826
Compare
Could you please rebase your PR and fix merge conflicts? |
e56741f
to
c07db02
Compare
I found another bug here :( UpdateAdd priority resolve this issue: $container->addCompilerPass(new TwigStringExtensionCompilerPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 1); |
c07db02
to
b92b12e
Compare
b92b12e
to
7d4f19c
Compare
7d4f19c
to
dbbe2ff
Compare
Note: PHPStan is failing. |
PHPStan failing becouse CoreBundle id optional. I think this should be fix in dev-kit. |
No, it is fixed here: #6161 |
Let's merge this then ; the phpstan will be fixed. |
Thank you @wbloszyk |
Subject
sonata-project/intl-bundle
andtwig/intl-extra
registerformat_datetime
what make them in conflict.twig/extra-bundle
require-devtwig/intl-extra
and auto-register it in twig. This will not allow use last SonataAdminBundle releases with some bundles likeecommerce
.I am targeting this branch, because this change respect BC.
Closes #6169.
Changelog