Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu label translation #6112

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Menu label translation #6112

merged 1 commit into from
Jul 15, 2020

Conversation

pavol-tuka
Copy link
Contributor

@pavol-tuka pavol-tuka commented May 27, 2020

Subject

Allow to use parameters/placeholders in (sidebar) menu label.

translations/messages.en.yaml

item_label_translation: Translatable label with %placeholder%.

Menu builder:

$group->addChild('item', [
    'label' => 'item_label_translation',
    'labelAttributes' => ['%placeholder%' => 'dynamic_value']
]);

Changelog

### Fixed
- Allow to use parameters/placeholders in (sidebar) menu label translation.

@pavol-tuka
Copy link
Contributor Author

ping @VincentLanglet

VincentLanglet
VincentLanglet previously approved these changes Jun 9, 2020
@VincentLanglet VincentLanglet requested a review from a team June 9, 2020 12:36
@pavol-tuka pavol-tuka closed this Jun 9, 2020
@VincentLanglet
Copy link
Member

Why did you close this @pavol-tk ?

@pavol-tuka pavol-tuka reopened this Jun 9, 2020
@VincentLanglet
Copy link
Member

Hi @pavol-tk, let's try to merge this PR !
Can you squash your commit ? You'll maybe need to rebase 3.x too.

@sonata-project/contributors, if someone wanna review.

VincentLanglet
VincentLanglet previously approved these changes Jun 28, 2020
core23
core23 previously approved these changes Jun 29, 2020
@pavol-tuka
Copy link
Contributor Author

Changelog added

@VincentLanglet VincentLanglet requested a review from phansys July 1, 2020 10:19
jordisala1991
jordisala1991 previously approved these changes Jul 3, 2020
@jordisala1991
Copy link
Member

Please can you rebase so all builds passes?

@pavol-tuka pavol-tuka dismissed stale reviews from jordisala1991, core23, and VincentLanglet via 2ebf8ad July 5, 2020 08:20
jordisala1991
jordisala1991 previously approved these changes Jul 13, 2020
@jordisala1991 jordisala1991 requested review from core23, VincentLanglet and a team July 13, 2020 19:09
phansys
phansys previously approved these changes Jul 14, 2020
src/Resources/views/Menu/sonata_menu.html.twig Outdated Show resolved Hide resolved
@jordisala1991
Copy link
Member

@pavol-tk can you make the suggested change?

jordisala1991
jordisala1991 previously approved these changes Jul 15, 2020
@jordisala1991 jordisala1991 requested a review from phansys July 15, 2020 05:47
phansys
phansys previously approved these changes Jul 15, 2020
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @pavol-tk.
Could you please squash your commits?

@pavol-tuka pavol-tuka dismissed stale reviews from phansys and jordisala1991 via 373eaa2 July 15, 2020 12:16
@jordisala1991 jordisala1991 requested a review from phansys July 15, 2020 12:36
@jordisala1991 jordisala1991 merged commit 31e7c24 into sonata-project:3.x Jul 15, 2020
@jordisala1991
Copy link
Member

Thank you @pavol-tk

@pavol-tuka pavol-tuka deleted the menu-label-translation branch July 15, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants