Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consistency in FieldDescriptionRegistryInterface and implementation #6104

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Add consistency in FieldDescriptionRegistryInterface and implementation #6104

merged 1 commit into from
Jun 10, 2020

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented May 24, 2020 •
edited
Loading

Subject

I am targeting this branch, because BC.

Related to #6035

Changelog

### Deprecated
- Calling `getFormFieldDescription` without using `hasFormFieldDescription` before.
- Calling `getShowFieldDescriptions ` without using `hasShowFieldDescription` before.
- Calling `getFilterFieldDescription` without using `hasFilterFieldDescription` before.

I also add some consistency in the FieldDescriptionRegistryInterface and the behaviour of the xxxFormFieldDescription, xxxListFieldDescriptions, xxxFormFieldDescriptions and xxxFilterFieldDescriptions methods.

@VincentLanglet VincentLanglet force-pushed the FieldDescriptionRegistryInterface branch 4 times, most recently from 4fe87e0 to c680ec0 Compare May 24, 2020 21:05
@VincentLanglet VincentLanglet force-pushed the FieldDescriptionRegistryInterface branch from c680ec0 to 3053f2b Compare May 24, 2020 21:44
@VincentLanglet VincentLanglet marked this pull request as ready for review May 24, 2020 21:53
@VincentLanglet VincentLanglet requested review from a team and phansys May 24, 2020 21:58
@VincentLanglet
Copy link
Member Author

Can you take a look @sonata-project/contributors ?

@VincentLanglet VincentLanglet requested a review from a team June 9, 2020 21:12
@VincentLanglet VincentLanglet merged commit 1c411ab into sonata-project:3.x Jun 10, 2020
@VincentLanglet VincentLanglet deleted the FieldDescriptionRegistryInterface branch June 10, 2020 13:11
@VincentLanglet VincentLanglet mentioned this pull request Jun 10, 2020
Merged
@jtaylor100 jtaylor100 mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@greg0ire greg0ire greg0ire approved these changes

@phansys phansys Awaiting requested review from phansys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @greg0ire @core23