Using sprintf() is preferred over string concatenation #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Apr 28, 2020
|
Could you please rebase your PR and fix merge conflicts? |
1 similar comment
|
Could you please rebase your PR and fix merge conflicts? |
|
Could you please rebase your PR and fix merge conflicts? |
3 similar comments
|
Could you please rebase your PR and fix merge conflicts? |
|
Could you please rebase your PR and fix merge conflicts? |
|
Could you please rebase your PR and fix merge conflicts? |
peter-gribanov
force-pushed
the
sprintf
branch
4 times, most recently
from
ca6566d to
76562f1
Compare
VincentLanglet
requested changes
Jun 30, 2020
peter-gribanov
force-pushed
the
sprintf
branch
2 times, most recently
from
1529a3d to
dafd02d
Compare
VincentLanglet
previously approved these changes
Jul 1, 2020
greg0ire
previously approved these changes
Jul 1, 2020
jordisala1991
previously approved these changes
Jul 1, 2020
phansys
reviewed
Jul 1, 2020
use multiline throw change position of concatenation character remove duplicates in sprintf() arguments
peter-gribanov
dismissed stale reviews from jordisala1991, greg0ire, and VincentLanglet
via
6018907
VincentLanglet
approved these changes
Jul 2, 2020
jordisala1991
approved these changes
Jul 2, 2020
|
Thank you @peter-gribanov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
As i was told, this project adopted the Symfony coding style. But this coding style is not always respected, which leads to problems when making changes to the project code. In this PR, i fix some coding style errors.