Add AdminExtractor #6040
Merged
Add AdminExtractor #6040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
add_symfony_extractor
branch
2 times, most recently
from
6249612 to
15e199a
Compare
|
Please have a look at the FlintCI failures |
greg0ire
reviewed
Apr 11, 2020
greg0ire
reviewed
Apr 11, 2020
greg0ire
reviewed
Apr 11, 2020
greg0ire
reviewed
Apr 11, 2020
|
I removed the logger since I think it's not useful here. The FlintCI failures are #6039. |
phansys
requested changes
Apr 11, 2020
franmomu
force-pushed
the
add_symfony_extractor
branch
from
25f7f51 to
e6839f0
Compare
phansys
requested changes
Apr 11, 2020
franmomu
force-pushed
the
add_symfony_extractor
branch
2 times, most recently
from
6d60490 to
d2788a3
Compare
phansys
previously approved these changes
Apr 11, 2020
OskarStark
reviewed
Apr 13, 2020
| } | ||
| } | ||
|
|
||
| public function setPrefix($prefix): void |
There was a problem hiding this comment.
Can we add string typehint here?
There was a problem hiding this comment.
This is from ExtractorInterface.
| $this->prefix = $prefix; | ||
| } | ||
|
|
||
| public function getLabel($label, $context = '', $type = ''): string |
There was a problem hiding this comment.
This is from LabelTranslatorStrategyInterface.
franmomu
force-pushed
the
add_symfony_extractor
branch
from
d2788a3 to
664ff13
Compare
greg0ire
previously approved these changes
Apr 13, 2020
core23
requested changes
Apr 16, 2020
franmomu
force-pushed
the
add_symfony_extractor
branch
from
664ff13 to
442e5ef
Compare
franmomu
force-pushed
the
add_symfony_extractor
branch
2 times, most recently
from
19b7485 to
f68066d
Compare
VincentLanglet
previously approved these changes
Apr 16, 2020
phansys
requested changes
Apr 17, 2020
phansys
reviewed
Apr 17, 2020
franmomu
force-pushed
the
add_symfony_extractor
branch
from
f68066d to
728bec7
Compare
phansys
previously approved these changes
Jul 1, 2020
franmomu
force-pushed
the
add_symfony_extractor
branch
from
728bec7 to
4b3ce7f
Compare
VincentLanglet
approved these changes
Jul 2, 2020
phansys
approved these changes
Jul 2, 2020
core23
approved these changes
Jul 2, 2020
jordisala1991
approved these changes
Jul 2, 2020
|
Thank you @franmomu |
This was referenced Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
The current
AdminExtractoris usingJMSTranslationBundle. I added a newAdminExtractorthat usestranslation.extractorSymfony tag, so there is no need of the JMS bundle dependency.The class is a copy of the other one with some changes. The old one implements
TranslatorInterfaceso it's injected to the admin instances and whenAdminInterface::transis called, it registers it into the catalogue. SinceAdminInterface::transis deprecated, the new extractor does not look into these calls anymore, just to the ones made by theLabelTranslatorStrategy.I am targeting this branch, because this is BC.
Changelog