Fix explicitly set use_intl_templates #5979
Conversation
|
Can you add a function test to cover this bug? |
This one covers that case. |
|
Restarting Travis to see if it works... |
|
I think there is an ongoing scheduled maintenance: https://twitter.com/traviscistatus |
| @@ -212,7 +212,9 @@ public function prepend(ContainerBuilder $container) | |||
| $configs = $container->getExtensionConfig($this->getAlias()); | |||
| $config = $this->processConfiguration(new Configuration(), $configs); | |||
|
|
|||
| $useIntlTemplates = $config['use_intl_templates'] || isset($bundles['SonataIntlBundle']); | |||
| $defaultUseIntlTemplates = $config['use_intl_templates'] || isset($bundles['SonataIntlBundle']); | |||
There was a problem hiding this comment.
This is correct? I must use the intl templates if i installed the SonataIntlBundle?
There was a problem hiding this comment.
Before #5835, when you had installed SonataIntlBundle, the intl templates were automatically loaded from SonataIntlBundle. This simulated that behaviour.
The problem was that if you set use_intl_templates to false (explicitly) with the SonataIntlBundle installed, it did't matter, it was like it was set to true. Now this is fixed by the next line. So to sum up:
SonataIntlBundleinstalled and nothing configured: it uses intl templatesSonataIntlBundlenot installed butuse_intl_templatesset totrue: it loades intl templates- No matter if
SonataIntlBundleis installed if you setuse_intl_templatestofalse: it won't load intl templates
|
You should update the docs too. |
|
Could you please rebase your PR and fix merge conflicts? |
Subject
Ref: #5977
Basically, when
use_intl_templateswas explicitly set tofalsebut withSonataIntlBundleenabled, it kept loading the intl templates.I am targeting this branch, because this is BC.
Closes #5977
Changelog
To test:
composer config repositories.franmomu vcs https://github.com/franmomu/SonataAdminBundle composer require sonata-project/admin-bundle "dev-fix_override_use_intl_templates as 3.62.1"PS: I'll try later to add the missing services to #5975