-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-existent parameter #5963
Conversation
099046f
to
54d5172
Compare
8f60920
to
1300236
Compare
That's what I would have tried too |
4d4953e
to
647b2db
Compare
We were in the right path I think, but looks like this line is not loading properly the configuration inside the |
@dmaicher can you please test the fix? @franmomu you may use this script to provide instructions: https://gist.github.com/greg0ire/a404831add1247d2bc20fa11107c5d5e |
nice! composer config repositories.franmomu vcs https://github.com/franmomu/SonataAdminBundle
composer require sonata-project/admin-bundle "dev-fix_is_parameter as 3.62.0" I'm going to extract the test I added to a class. |
9e78864
to
050e208
Compare
050e208
to
13424fb
Compare
Thanks @franmomu , I'm releasing this! |
Subject
In AbstractSonataAdminExtension I added this line:
This is class is extended in other bundles, so the problem is that depending on the order of how the bundles are registered works or not (if the AdminBundle is registered first works).
I am targeting this branch, because this is a patch.
Closes #5961
Changelog
I only could come up with this solution, any other way/help is appreciated.
I can't take a further look until this evening/night.