allow to change 'label_translator_strategy' for all admins at global config of 'sonata_admin.admin_services' key #4637
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -245,36 +245,35 @@ public function getConfigTreeBuilder() | |
| ->end() | ||
| ->end() | ||
| ->arrayNode('admin_services') | ||
|
There was a problem hiding this comment. Uuuuuh why did you remove this? There was a problem hiding this comment. this already defining the global node type, and mentioned ->prototype('array') breaks underlying nodes, configuration in yml doesn't work and throws that error as in #3190 . There was a problem hiding this comment. I think you are removing the ability to set admin services on an admin per admin basis when doing that, aren't you? Why not create a |
||
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->scalarNode('model_manager')->defaultNull()->end() | ||
| ->scalarNode('form_contractor')->defaultNull()->end() | ||
| ->scalarNode('show_builder')->defaultNull()->end() | ||
| ->scalarNode('list_builder')->defaultNull()->end() | ||
| ->scalarNode('datagrid_builder')->defaultNull()->end() | ||
| ->scalarNode('translator')->defaultNull()->end() | ||
| ->scalarNode('configuration_pool')->defaultNull()->end() | ||
| ->scalarNode('route_generator')->defaultNull()->end() | ||
| ->scalarNode('validator')->defaultNull()->end() | ||
| ->scalarNode('security_handler')->defaultNull()->end() | ||
| ->scalarNode('label')->defaultNull()->end() | ||
| ->scalarNode('menu_factory')->defaultNull()->end() | ||
| ->scalarNode('route_builder')->defaultNull()->end() | ||
| ->scalarNode('label_translator_strategy')->defaultNull()->end() | ||
| ->scalarNode('pager_type')->defaultNull()->end() | ||
| ->arrayNode('templates') | ||
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->arrayNode('form') | ||
| ->prototype('scalar')->end() | ||
| ->end() | ||
| ->arrayNode('filter') | ||
| ->prototype('scalar')->end() | ||
| ->end() | ||
| ->arrayNode('view') | ||
| ->useAttributeAsKey('id') | ||
| ->prototype('scalar')->end() | ||
| ->end() | ||
| ->end() | ||
| ->end() | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this code supposed to achieve the exact same goal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean $definition->addMethodCall($method, $args); ?
currently 'label_translator_strategy' => 'sonata.admin.label.strategy.native' is hardcoded, and there is no way to globaly change the stratagy, only one by one for each admin service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I missed the fact that
$settingsis not$overwriteAdminConfiguration.Anyway, if other properties
sonata_admin.admin_services.*work out of the box (I mean without such ternary condition here), I don't get why you have to override this one here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about other properties yet. I was needed to change the label translation strategy for all my admin services and faced this issue
but i guess this settings will have similar issue if will try to set them in a global configuration area
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I asked. Could you test if they work? If not we will need a fix for all of them with a cleaner solution.