Removed alias from ModelManagerInterface::createQuery (#6559)

$alias parameter does not make sense in an persistence agnostic environment.
sonata-project · Dec 5, 2020 · e29ffa2 · e29ffa2
1 parent 29bbbb0
commit e29ffa2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/UPGRADE-3.x.md b/UPGRADE-3.x.md
@@ -4,6 +4,10 @@ UPGRADE 3.x
 UPGRADE FROM 3.xx to 3.xx
 =========================
 
+### Sonata\AdminBundle\Model\ModelManagerInterface
+
+Argument 2 of `Sonata\AdminBundle\Model\ModelManagerInterface::createQuery()` method has been removed.
+
 ### Sonata\AdminBundle\Admin\Pool
 
 - Passing a `Symfony\Component\PropertyAccess\PropertyAccessorInterface` instance as 4 argument instantiating

diff --git a/src/Model/ModelManagerInterface.php b/src/Model/ModelManagerInterface.php
@@ -119,13 +119,12 @@ public function getParentFieldDescription($parentAssociationMapping, $class);
 
     /**
      * @param string $class
-     * @param string $alias
      *
      * @return ProxyQueryInterface
      *
      * @phpstan-param class-string $class
      */
-    public function createQuery($class, $alias = 'o');
+    public function createQuery($class);
 
     /**
      * Get the identifier for the model type of this class.