Drop check php 8.0 in tests (#8228)

sonata-project · Dec 7, 2024 · a43b3c9 · a43b3c9
1 parent db99910
commit a43b3c9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 32 deletions.
diff --git a/tests/Form/DataTransformer/BackedEnumTransformerTest.php b/tests/Form/DataTransformer/BackedEnumTransformerTest.php
@@ -19,9 +19,6 @@
 use Symfony\Component\Form\Exception\TransformationFailedException;
 use Symfony\Component\Form\Exception\UnexpectedTypeException;
 
-/**
- * @requires PHP 8.1
- */
 final class BackedEnumTransformerTest extends TestCase
 {
     public function testReverseTransform(): void

diff --git a/tests/Twig/Extension/RenderElementExtensionTest.php b/tests/Twig/Extension/RenderElementExtensionTest.php
@@ -1523,11 +1523,6 @@ class="x-editable"
             ],
         ];
 
-        // TODO: Remove the "if" check when dropping support of PHP < 8.1 and add the case to the list
-        if (\PHP_VERSION_ID < 80100) {
-            return $elements;
-        }
-
         $elements[] = [
             '<td class="sonata-ba-list-field sonata-ba-list-field-enum" objectId="12345"> &nbsp; </td>',
             FieldDescriptionInterface::TYPE_ENUM,
@@ -2103,11 +2098,6 @@ class="sonata-readmore"
             ],
         ];
 
-        // TODO: Remove the "if" check when dropping support of PHP < 8.1 and add the case to the list
-        if (\PHP_VERSION_ID < 80100) {
-            return $elements;
-        }
-
         $elements[] = [
             '<th>Data</th> <td>Hearts</td>',
             FieldDescriptionInterface::TYPE_ENUM,

diff --git a/tests/Twig/RenderElementRuntimeTest.php b/tests/Twig/RenderElementRuntimeTest.php
@@ -1473,11 +1473,6 @@ class="x-editable"
             ],
         ];
 
-        // TODO: Remove the "if" check when dropping support of PHP < 8.1 and add the case to the list
-        if (\PHP_VERSION_ID < 80100) {
-            return $elements;
-        }
-
         $elements[] = [
             '<td class="sonata-ba-list-field sonata-ba-list-field-enum" objectId="12345"> Hearts </td>',
             FieldDescriptionInterface::TYPE_ENUM,

diff --git a/tests/Twig/XEditableRuntimeTest.php b/tests/Twig/XEditableRuntimeTest.php
@@ -93,19 +93,16 @@ public function provideGetXEditableChoicesIsIdempotentCases(): iterable
             ],
         ];
 
-        // TODO: Remove the "if" check when dropping support of PHP < 8.1 and add the case to the list
-        if (\PHP_VERSION_ID >= 80100) {
-            yield 'enum cases' => [
-                [
-                    'required' => false,
-                    'multiple' => false,
-                    'choices' => [Suit::Hearts, Suit::Clubs],
-                ],
-                [
-                    ['value' => 'H', 'text' => 'Hearts'],
-                    ['value' => 'C', 'text' => 'Clubs'],
-                ],
-            ];
-        }
+        yield 'enum cases' => [
+            [
+                'required' => false,
+                'multiple' => false,
+                'choices' => [Suit::Hearts, Suit::Clubs],
+            ],
+            [
+                ['value' => 'H', 'text' => 'Hearts'],
+                ['value' => 'C', 'text' => 'Clubs'],
+            ],
+        ];
     }
 }