Avoid to pass empty array as argument 3 for implementations of `Model…

…ManagerInterface::addIdentifiersToQuery()`
sonata-project · Oct 20, 2020 · 8e9583b · 8e9583b
1 parent 622d7b8
commit 8e9583b
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 5 deletions.
diff --git a/src/Form/DataTransformer/ModelsToArrayTransformer.php b/src/Form/DataTransformer/ModelsToArrayTransformer.php
@@ -167,11 +167,14 @@ public function reverseTransform($value)
             throw new UnexpectedTypeException($value, 'array');
         }
 
-        $value = array_map('strval', $value);
-
-        $query = $this->modelManager->createQuery($this->class);
-        $this->modelManager->addIdentifiersToQuery($this->class, $query, $value);
-        $result = $this->modelManager->executeQuery($query);
+        if ([] === $value) {
+            $result = $value;
+        } else {
+            $value = array_map('strval', $value);
+            $query = $this->modelManager->createQuery($this->class);
+            $this->modelManager->addIdentifiersToQuery($this->class, $query, $value);
+            $result = $this->modelManager->executeQuery($query);
+        }
 
         /** @phpstan-var ArrayCollection<array-key, T> $collection */
         $collection = TraversableToCollection::transform($result);

diff --git a/tests/Form/DataTransformer/ModelsToArrayTransformerTest.php b/tests/Form/DataTransformer/ModelsToArrayTransformerTest.php
@@ -90,6 +90,30 @@ public function reverseTransformProvider(): iterable
         yield [null];
     }
 
+    public function testReverseTransformWithEmptyArray(): void
+    {
+        $modelManager = $this->createStub(ModelManagerInterface::class);
+        $modelManager
+            ->expects($this->never())
+            ->method('createQuery');
+        $modelManager
+            ->expects($this->never())
+            ->method('addIdentifiersToQuery');
+        $modelManager
+            ->expects($this->never())
+            ->method('executeQuery');
+
+        $transformer = new ModelsToArrayTransformer(
+            $modelManager,
+            Foo::class
+        );
+
+        $result = $transformer->reverseTransform([]);
+
+        $this->assertInstanceOf(Collection::class, $result);
+        $this->assertCount(0, $result);
+    }
+
     public function testReverseTransformUnexpectedType(): void
     {
         $value = 'unexpected';