DevKit updates for 4.x branch (#8195)

Co-authored-by: Vincent Langlet <[email protected]>
sonata-project · Jul 15, 2024 · 64c6e28 · 64c6e28
1 parent 77db467
commit 64c6e28
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/rector.php b/rector.php
@@ -19,7 +19,6 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Php70\Rector\FunctionLike\ExceptionHandlerTypehintRector;
-use Rector\PHPUnit\CodeQuality\Rector\Class_\AddSeeTestAnnotationRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
 use Rector\PHPUnit\Set\PHPUnitSetList;
 use Rector\Set\ValueObject\LevelSetList;
@@ -40,7 +39,6 @@
     $rectorConfig->importShortClasses(false);
     $rectorConfig->skip([
         ExceptionHandlerTypehintRector::class,
-        AddSeeTestAnnotationRector::class,
         PreferPHPUnitThisCallRector::class,
     ]);
 };
diff --git a/src/Admin/AbstractAdmin.php b/src/Admin/AbstractAdmin.php
@@ -1840,7 +1840,7 @@ protected function generateBaseRoutePattern(bool $isChildAdmin = false): string
 
         preg_match(self::CLASS_REGEX, $this->getModelClass(), $matches);
 
-        if ([] === $matches) {
+        if (!isset($matches[1], $matches[3], $matches[5])) {
             throw new \LogicException(sprintf(
                 'Please define a default `baseRoutePattern` value for the admin class `%s`',
                 static::class
@@ -1877,7 +1877,7 @@ protected function generateBaseRouteName(bool $isChildAdmin = false): string
 
         preg_match(self::CLASS_REGEX, $this->getModelClass(), $matches);
 
-        if ([] === $matches) {
+        if (!isset($matches[1], $matches[3], $matches[5])) {
             throw new \LogicException(sprintf(
                 'Cannot automatically determine base route name,'
                 .' please define a default `baseRouteName` value for the admin class `%s`',