This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
forked from rande/GoogleAuthenticator
-
Notifications
You must be signed in to change notification settings - Fork 118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
reviewed
Feb 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe go to the latest stable release? It's a Dev dependency only
might as well |
Should I do the same for |
^2.1 should be fine enough if we depend on new fixers |
Done |
greg0ire
force-pushed
the
remove_pipes
branch
from
February 11, 2017 16:20
ac01e16
to
204a4a2
Compare
And after this PR, I think we should release 2.0. |
core23
approved these changes
Feb 11, 2017
core23
approved these changes
Feb 12, 2017
Before releasing a new major release, we should have a look at: sonata-project/dev-kit#184 |
Only the vendor prefix is major IMO. |
OskarStark
approved these changes
Feb 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only test dependencies were touched, so this is pedantic.