Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Drop old versions of dependencies #50

Merged
merged 2 commits into from
Feb 13, 2017

Conversation

greg0ire
Copy link

Only test dependencies were touched, so this is pedantic.

Copy link
Member

@core23 core23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe go to the latest stable release? It's a Dev dependency only

@greg0ire
Copy link
Author

might as well

@greg0ire
Copy link
Author

Should I do the same for sllh/php-cs-fixer-styleci-bridge? And if yes, ^2.1.1 or ^2.1… not sure if this makes much sense after all… or even if this PR does.

@core23
Copy link
Member

core23 commented Feb 11, 2017

^2.1 should be fine enough if we depend on new fixers

@greg0ire
Copy link
Author

Done

@greg0ire
Copy link
Author

And after this PR, I think we should release 2.0.

@core23
Copy link
Member

core23 commented Feb 12, 2017

Before releasing a new major release, we should have a look at: sonata-project/dev-kit#184

@greg0ire
Copy link
Author

Only the vendor prefix is major IMO.

@OskarStark OskarStark merged commit 00d8ebc into sonata-project:master Feb 13, 2017
@greg0ire greg0ire deleted the remove_pipes branch February 13, 2017 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants