Improve typehint

[VincentLanglet]

Subject

I am targeting this branch, because BC.

The $revision param is often restrict to int but could work with string too. (and SonataAdmin is using int|string).
The $id seems to only work with int|string|array if I read the code.

I also add some typehint for constructor or Exception/Object we're using.

This will fix some errors from https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/1386/checks?check_run_id=2265615169

Changelog

### Added
- Allow `$revisions` param to be a string in `AuditManager` methods.

### Deprecated
- Passing another value than 'string', 'integer', 'smallint', 'bigint' or 'guid' for the `revision_id_field_type` value.

[phansys]

Checking the configuration, the revision id seems to accept anything:

EntityAuditBundle/src/DependencyInjection/Configuration.php

Line 39 in a800c2a

->scalarNode('revision_id_field_type')->defaultValue('integer')->end()

Maybe we could restrict the config to "integer" and "string".

[VincentLanglet]

Maybe we could restrict the config to "integer" and "string".

It would be a BC-break no ? I think we will be able to restrict only for the next major...

[phansys]

It would be a BC-break no ? I think we will be able to restrict only for the next major...

Yes. We should deprecate the types that we consider invalid before.

[VincentLanglet]

@phansys There is the following code:

$revisionsTable->addColumn('id', $this->config->getRevisionIdFieldType(), [
            'autoincrement' => true,
        ]);

Would it work with string ?

[phansys]

Would it work with string ?

I think the autoincrement option is ignored for other types.

[franmomu]

what about enumNode instead?

[VincentLanglet]

Didn't know this.

[franmomu]

Suggested change

	public function __construct(?string $className, ?array $id, $revision)
	/**
	* @param int|string|null $revision
	*/
	public function __construct(?string $className, ?array $id, $revision)