fix: failed to save note in windows by removing invisible characters …

…in the filename

package.json

@@ -49,6 +49,7 @@
 		"luxon": "^3.1.1",
 		"markdown-escape": "^2.0.0",
 		"mustache": "^4.2.0",
+		"out-of-character": "^1.2.1",
 		"process": "^0.11.10"
 	},
 	"volta": {

src/__tests__/path_validation.spec.ts

@@ -19,6 +19,8 @@ const expectedManualIllegalChars: string[] = [
   "\u001F",
 ];
 
+const expectedInvisibleChars: string[] = ["­", "‍"];
+
 describe("replaceIllegalChars() removes all expected characters", () => {
   test.each(expectedManualIllegalChars)(
     'Illegal character "%s" is removed',
@@ -97,3 +99,16 @@ describe("file system behavior with non-alphanumeric characters not in the illeg
     }
   );
 });
+
+describe("replaceIllegalChars() function removes all occurrences of invisible characters", () => {
+  test.each(expectedInvisibleChars)(
+    "Invisible character '%s' is replaced",
+    (char) => {
+      const input = `${char}foo${char}bar`;
+      const expectedOutput = "foobar";
+      const output = replaceIllegalChars(input);
+      expect(output).toEqual(expectedOutput);
+      expect(output.match(ILLEGAL_CHAR_REGEX)).toBeNull();
+    }
+  );
+});

src/util.ts

@@ -2,6 +2,7 @@ import { diff_match_patch } from "diff-match-patch";
 import { DateTime } from "luxon";
 import escape from "markdown-escape";
 import { parseYaml } from "obsidian";
+import { replace } from "out-of-character";
 import { Highlight } from "./api";
 
 export const DATE_FORMAT_W_OUT_SECONDS = "yyyy-MM-dd'T'HH:mm";
@@ -91,7 +92,8 @@ export const unicodeSlug = (str: string, savedAt: string) => {
 };
 
 export const replaceIllegalChars = (str: string): string => {
-  return str.replace(ILLEGAL_CHAR_REGEX, REPLACEMENT_CHAR);
+  // remove invisible characters
+  return replace(str.replace(ILLEGAL_CHAR_REGEX, REPLACEMENT_CHAR));
 };
 
 export function formatDate(date: string, format: string): string {