Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #[derive(Debug,PartialEq,Eq)] no longer working #93

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

jaysonmaw
Copy link
Contributor

Intended to fix #92

Seems that all the derive's were no longer working

The bug was introduced in b1cbf32

body previously would resolve to a stream of one TokenTree::Group with a stream inside but after this change body is a stream of TokenTree::Ident and TokenTree::Punct

Skipping the "unwrap" of the TokenTree::Group and sending the stream directly to parse_derive_token fixed the issue.

@jaysonmaw
Copy link
Contributor Author

I also wonder if it would be a good idea to add a derive attribute onto one of the examples so that it will fail the tests?
(Assuming that's how the CI works, I'm not familiar)

Could also state in the examples or docs that only those 3 derives work, unless I missed it I didn't know until I dug into the code to look for this bug.

@someguynamedjosh someguynamedjosh merged commit 67971e2 into someguynamedjosh:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

derive(Debug) does not compile
2 participants