Implement the third set of NRBC treatment for 1D Euler solver #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the 1D Euler solver, implement the third set of NRBC treatment documented in NASA/TM-2003-212495-REV1, i.e., NRBC type 3.$\lambda$ is chosen to be 0.
Here copying the type-3 NRBC treatment (the third set of NRBC in section 4.3 in page 15 of the TM) at the right and left boundaries, respectively:
Choosing$\lambda=0$ , the treatment becomes:
After implementing the type-3 NRBC treatment, waves go outside the boundary:
Comparing with the result with the tentatively implemented (and wrong) BC treatment: