Add some support for custom proxies #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New flags added for - customProxyPort - disableReadinessProbe - customProxyReadinessPath - env vars Also updated viper to include bug fix for StringArrayP spf13/viper#398 Signed-off-by: stoobmmelier <>
stoobmmelier
force-pushed
the
support-custom-proxies
branch
from
5411c33 to
49c12fb
Compare
|
Hi @Eriner , big fan of your project and wanted to add some extra things for my own workflow, wondering if I could get your review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New flags added for
Also updated viper to include bug fix for StringArrayP
spf13/viper#398