add DCO, add note about ig-test pf delay

soluble-ai · May 21, 2020 · 0d0f240 · 0d0f240
1 parent b2ee2fd
commit 0d0f240
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/docs/kubetap_development/TODOs.md b/docs/kubetap_development/TODOs.md
@@ -52,10 +52,3 @@ Don't want to force alpha features on anyone, but once this is in beta this will
 probably be the way forward. Will revisit.
 
 https://kubernetes.io/docs/concepts/workloads/pods/ephemeral-containers/
-
-## Management
-
-### Add DCO
-
-https://probot.github.io/apps/dco/
-
diff --git a/scripts/ig-test.zsh b/scripts/ig-test.zsh
@@ -76,7 +76,9 @@ if (( readyCt != 1 )); then
 fi
 unset readyCt
 
-sleep 10
+# without a delay here, port forwards occasionally fail. Need
+# to implement kubectl ready check like in kubetap.
+sleep 15
 kubectl port-forward svc/grafana -n default 2244:2244 &
 _kubetap_pf_one_pid=${!}
 kubectl port-forward svc/grafana -n default 4000:80 &
@@ -117,7 +119,9 @@ if (( readyCt != 1 )); then
 fi
 unset readyCt
 
-sleep 10
+# without a delay here, port forwards occasionally fail. Need
+# to implement kubectl ready check like in kubetap.
+sleep 15
 kubectl port-forward svc/dw-dokuwiki -n default 2244:2244 &
 _kubetap_pf_one_pid=${!}
 kubectl port-forward svc/dw-dokuwiki -n default 4000:80 &