No longer start any service by default #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
solsson/kafka
, environments that did the 100k pull so far might break, and I prefer them to not start, compared to for example silently reverting config.Motivation for avoiding all config overrides:
cp-kafka
or https://github.com/kubernetes/contrib/tree/master/statefulsets/kafka. Of course this depends on how you've configured your services, but it's a noble thought :)