Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio 1.8 support #210

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Istio 1.8 support #210

merged 4 commits into from
Oct 27, 2020

Conversation

Sodman
Copy link
Member

@Sodman Sodman commented Oct 26, 2020

Description

Adds support for deploying wasm filters to Istio 1.8.x.

Context

The release of Istio 1.8.x is coming up, so we want to make sure users can deploy to it right away once it's out.

This PR adds support to wasme to deploy wasm filters to Istio 1.8.x.

The ABI used by Istio 1.7.x is compatible with Istio 1.8.x so any filters built for Istio 1.7.x should work in 1.8.x.

Notes:

  • Tested against Istio release istio-1.8.0-alpha.0
  • Tested CPP filter webassemblyhub.io/sodman/istio-1-7:v0.3
  • Tested Rust filter webassemblyhub.io/sodman/rust-example:v0.2
  • Tested Assemblyscript with webassemblyhub.io/sodman/as-istio-1-7:v0.3
  • Tested Tinygo with webassemblyhub.io/sodman/tinygo-example:v0.1

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make install-deps generated-code from tools/wasme/cli to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@soloio-bulldozer soloio-bulldozer bot merged commit 8637c40 into master Oct 27, 2020
@soloio-bulldozer soloio-bulldozer bot deleted the istio-1-8 branch October 27, 2020 18:26
@Sodman Sodman mentioned this pull request Oct 28, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants