Skip to content

Commit

Permalink
Istioctl now needs --skip-confirmation to work
Browse files Browse the repository at this point in the history
  • Loading branch information
Sodman committed Oct 26, 2020
1 parent 4bbf260 commit d674eb6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tools/wasme/cli/ci/setup-kind-istio.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ kubectl apply -f https://raw.githubusercontent.com/solo-io/gloo/master/example/p
if [[ "$ISTIO_VERSION" == *"1.5"* ]]; then
istioctl manifest apply --set profile=minimal
else
istioctl install --set profile=minimal
istioctl install --set profile=minimal --skip-confirmation
fi

kubectl -n istio-system rollout status deployment istiod
Expand Down
2 changes: 1 addition & 1 deletion tools/wasme/cli/pkg/cmd/initialize/initialize.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ If --language, --platform, or --platform-version are not provided, the CLI will
fmt.Sprintf("The name of the target platform against which to build. Supported platforms are: %v", []string{"gloo", "istio"}))

cmd.PersistentFlags().StringVar(&opts.platform.Version, "platform-version", "",
fmt.Sprintf("The version of the target platform against which to build. Supported Istio versions are: %v. Supported Gloo versions are: %v", []string{abi.Version15x, abi.Version16x}, []string{abi.Version13x, abi.Version15x}))
fmt.Sprintf("The version of the target platform against which to build. Supported Istio versions are: %v. Supported Gloo versions are: %v", []string{abi.Version15x, abi.Version16x, abi.Version17x, abi.Version18x}, []string{abi.Version13x, abi.Version15x}))

cmd.PersistentFlags().BoolVar(&opts.disablePrompt, "disable-prompt", false,
"Disable the interactive prompt if a required parameter is not passed. If set to true and one of the required flags is not provided, wasme CLI will return an error.")
Expand Down

0 comments on commit d674eb6

Please sign in to comment.