Limit concurrent protoc instances #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilackarms
previously approved these changes
Aug 31, 2021
ilackarms
approved these changes
Aug 31, 2021
kfelter
reviewed
Mar 24, 2022
| if err != nil { | ||
| return nil, eris.Wrapf(err, "invalid value for MAX_CONCURRENT_PROTOCS: %s", s) | ||
| } | ||
| sem = make(chan struct{}, maxProtocs) |
There was a problem hiding this comment.
Does this chan need to be closed at some point?
There was a problem hiding this comment.
Original PR author here: No, closing go channels is only required when the business logic requires that you indicate that all data has been sent through the channel. Since channels are not backed by a file descriptor like a network connection or file on disk, closing them is purely semantic. Once the open channel goes out of scope it will be garbage collected like any other variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.