Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai semantic caching distance threshold API update #10494

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

EItanya
Copy link
Member

@EItanya EItanya commented Dec 16, 2024

Description

Rename and move the distance_threshold API for semantic caching

API changes

  • Deprecated score_threshold in redis message
  • Add distance_threshold into semantic_caching base message

Context

Currently the score_threshold isn't working correctly, and not working properly for Weaviate, so adding it to the top level so we can add it from the beginning as it's very important.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@EItanya EItanya requested a review from a team as a code owner December 16, 2024 17:40
Copy link

github-actions bot commented Dec 16, 2024

Visit the preview URL for this PR (updated for commit 840f88b):

https://gloo-edge--pr10494-eitanya-ai-semantic-4pbt8qz5.web.app

(expires Mon, 23 Dec 2024 21:00:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7440

@soloio-bulldozer soloio-bulldozer bot merged commit 3281719 into main Dec 16, 2024
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the eitanya/ai-semantic-caching-distance-threshold branch December 16, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants