Adds sync-gateway-api Make Target for Managing the Gateway API Version
#10446
+203
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
4 tasks
|
Visit the preview URL for this PR (updated for commit a669ad3): https://gloo-edge--pr10446-issue-10445-qzmnf8s0.web.app (expires Mon, 23 Dec 2024 19:10:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
jenshu
reviewed
Dec 5, 2024
ci/sync-gateway-crds.sh
Outdated
| GATEWAY_CRD_URL="https://github.com/kubernetes-sigs/gateway-api/releases/download/${CONFORMANCE_VERSION}/${CONFORMANCE_CHANNEL}-install.yaml" | ||
| TCPROUTE_CRD_URL="https://raw.githubusercontent.com/kubernetes-sigs/gateway-api/refs/tags/${CONFORMANCE_VERSION}/config/crd/experimental/gateway.networking.k8s.io_tcproutes.yaml" | ||
|
|
||
| # Header to prepend to the TCPRoute CRD file |
There was a problem hiding this comment.
To comply with Apache 2.0 licensing.
jenshu
reviewed
Dec 5, 2024
danehans
changed the title
danehans
changed the title
sync-gateway-api Make Target for Managing the Gateway API Version
danehans
force-pushed
the
issue_10445
branch
2 times, most recently
from
ca3135c to
4110d13
Compare
jenshu
reviewed
Dec 12, 2024
danehans
force-pushed
the
issue_10445
branch
from
1b1bd85 to
3df60f7
Compare
danehans
force-pushed
the
issue_10445
branch
from
3df60f7 to
7dff8a7
Compare
| } | ||
|
|
||
| # Update k8sgateway_api_version in nightly-tests/max_versions.env | ||
| update_max_versions_env() { |
There was a problem hiding this comment.
Just thinking aloud -- do we need to handle the min_versions.env file as well? I don't think we've outlined any process around GW API version matrix that gloo supports (e.g. N-1), so automating that file could be premature.
There was a problem hiding this comment.
I added #10495 to track the need for managing the minimum supported version.
Signed-off-by: Daneyon Hansen <[email protected]>
Signed-off-by: Daneyon Hansen <[email protected]>
Signed-off-by: Daneyon Hansen <[email protected]>
danehans
force-pushed
the
issue_10445
branch
from
7dff8a7 to
a669ad3
Compare
timflannagan
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
sync-gateway-crdsMake target for managing Gateway API CRDs.-
projects/gateway2/crds/tcproute-crd.yaml: Removes comments that do not exist when downloading the TCPRoute CRD from upstream ($TCPROUTE_CRD_URL).Fixes: #10445
BOT NOTES:
resolves #10445