Refactors TCPRoute e2e tests #10418
Merged
Refactors TCPRoute e2e tests #10418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
|
Visit the preview URL for this PR (updated for commit 8b52691): https://gloo-edge--pr10418-issue-10414-iczepusq.web.app (expires Thu, 05 Dec 2024 04:44:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
sam-heilbron
approved these changes
Nov 27, 2024
sam-heilbron
approved these changes
Nov 28, 2024
danehans
force-pushed
the
issue_10414
branch
from
244670e to
53a3be5
Compare
Signed-off-by: Daneyon Hansen <[email protected]>
danehans
force-pushed
the
issue_10414
branch
from
53a3be5 to
8b52691
Compare
4 tasks
nfuden
reviewed
Dec 2, 2024
| version: v1 | ||
| spec: | ||
| containers: | ||
| - image: gcr.io/k8s-staging-gateway-api/echo-basic:v20231214-v1.0.0-140-gf544a46e |
There was a problem hiding this comment.
nit: if we can link to upstream so that we stay in lock step that would be cool.
That being said this is an echo server that seems fairly stable as it goes all the way to ingress api and likely doesnt need much changing.
nfuden
approved these changes
Dec 2, 2024
kevin-shelaga
pushed a commit
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Daneyon Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors TCPRoute e2e tests to run in parallel, reduce flakes, and parameterize tests for reusability.
EventuallyObjectsNotExistto 60 seconds since deleting a namespace can take longer than then previous time (20 seconds).Eventuallyassertions to reduce flakes due to eventual consistency.Fixes #10414
BOT NOTES:
resolves #10414