-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/ginkgo: ensure admin server port is not selected dynamically #10406
Conversation
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit 5cd9011): https://gloo-edge--pr10406-sh-safe-ports-e2e-5zdtl8ef.web.app (expires Tue, 03 Dec 2024 21:18:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
Should all of the 8xxx and 9xxx ports be skipped? |
Hitting flakes that #10409 should address |
Description
Always skip 9095. when selecting a port dynamically
Context
The issue holds the context. It caused issues for me running tests locally, where requests were sent to the Gloo admin server instead of my local proxy. As a result, the test failed locally and caused toil trying to debug, when the issue was that it was sending the request to the wrong backend.
Testing steps
Run all tests:
in the logs, you will see:
and the next EnvoyInstance uses 9096.
Notes for reviewers
Checklist: