Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/ginkgo: ensure admin server port is not selected dynamically #10406

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

sam-heilbron
Copy link

Description

Always skip 9095. when selecting a port dynamically

Context

The issue holds the context. It caused issues for me running tests locally, where requests were sent to the Gloo admin server instead of my local proxy. As a result, the test failed locally and caused toil trying to debug, when the issue was that it was sending the request to the wrong backend.

Testing steps

Run all tests:

TEST_PKG=./test/e2e INVALID_TEST_REQS=skip make test

in the logs, you will see:

Retrying because : port 9095 is in deny list

and the next EnvoyInstance uses 9096.

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7307

Copy link

github-actions bot commented Nov 26, 2024

Visit the preview URL for this PR (updated for commit 5cd9011):

https://gloo-edge--pr10406-sh-safe-ports-e2e-5zdtl8ef.web.app

(expires Tue, 03 Dec 2024 21:18:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@ryanrolds
Copy link

Should all of the 8xxx and 9xxx ports be skipped?

@sam-heilbron
Copy link
Author

Hitting flakes that #10409 should address

@soloio-bulldozer soloio-bulldozer bot merged commit 6d74158 into main Nov 26, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sh/safe-ports-e2e branch November 26, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants