Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal Auth API #10352

Merged
merged 8 commits into from
Nov 16, 2024
Merged

Portal Auth API #10352

merged 8 commits into from
Nov 16, 2024

Conversation

jmhbh
Copy link

@jmhbh jmhbh commented Nov 14, 2024

Description

  • Adds a new portalAuth option to our extAuth API which will be the recommended API for securing HttpRoutes whose credentials are managed by Gloo Portal

API changes

Code changes

  • API changes only.

CI changes

  • None

Docs changes

  • Added

Context

See - https://github.com/solo-io/solo-projects/issues/7170#issuecomment-2477312186

Interesting decisions

  • None

Testing steps

Notes for reviewers

  • None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@jmhbh jmhbh changed the title portal auth api changes Portal Auth API Nov 14, 2024
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7170

Copy link

@SirNexus SirNexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@inFocus7 inFocus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, happy to approve after the open conversation is resolved 👍🏼

@jmhbh jmhbh merged commit 8f097f5 into main Nov 16, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants