[main up-port] Set opentelemetry span name in transformation filter (#368) #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add setOperation patch * Add changelog * Transformation initial implementation Should work but does not seem to at the moment * Implement unit test for setting span name * Update changelog * Remove extra entry from changelog * Do not override route.decorator.operation * Add test for null route in callbacks * Remove redundant call to setOperation This is the default value that is set from the HCM - we do not need to write it a second time.
|
Issues linked to changelog: |
nfuden
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setOperation patch
Add changelog
Transformation initial implementation
Should work but does not seem to at the moment
Implement unit test for setting span name
Update changelog
Remove extra entry from changelog
Do not override route.decorator.operation
Add test for null route in callbacks
Remove redundant call to setOperation
This is the default value that is set from the HCM - we do not need to write it a second time.