Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect shipping rates to shipments earlier in Stock::Coordinator #965

Merged
merged 3 commits into from
Mar 9, 2016
Merged

Connect shipping rates to shipments earlier in Stock::Coordinator #965

merged 3 commits into from
Mar 9, 2016

Commits on Mar 9, 2016

  1. Connect shipping rates to shipments earlier in Stock::Coordinator 

    This will give the estimator the information it needs to calculate
taxes correctly in the pending tax work.
    @jordan-brough
    jordan-brough committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    0684205 View commit details
    Browse the repository at this point in the history

  2. Update Spree::Stock::Estimator to require a package with more data 

    - The package passed to Spree::Stock::Estimator#shipping_rates must
  have its shipment assigned and that shipment must have its order
  assigned. This is needed for some upcoming tax work in to calculate
  taxes correctly.

- Spree::Stock::Estimator.new no longer accepts an order argument. The
  order will be fetched from the shipment.
    @jordan-brough
    jordan-brough committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    796ed7f View commit details
    Browse the repository at this point in the history

  3. Update Stock::Package#to_shipment to set the shipment address 

    This was being done immediately after calling #to_shipment and it
makes more sense to do it inside #to_shipment.
    @jordan-brough
    jordan-brough committed Mar 9, 2016
    Configuration menu
    Copy the full SHA
    2842412 View commit details
    Browse the repository at this point in the history