Fix license issues #6084
Open
Fix license issues #6084
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:repository
Added Inter License Corrected Reference to other License file Update LICENSE.md formating Update License.md with reference to other licenses Added License for Remixicon
fthobe
force-pushed
the
Fix-License-Issues
branch
from
a7f7a88 to
f9209f1
Compare
|
@tvdeyen could you also look here |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6084 +/- ##
==========================================
+ Coverage 89.33% 89.58% +0.24%
==========================================
Files 730 801 +71
Lines 16462 18275 +1813
==========================================
+ Hits 14706 16371 +1665
- Misses 1756 1904 +148 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
Jan 22, 2025
| @@ -11,3 +15,5 @@ Redistribution and use in source and binary forms, with or without modification, | |||
| * Neither the name of Spree Commerce Inc. nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. | |||
|
|
|||
| _This software is provided by the copyright holders and contributors "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the copyright owner of contributors be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this software, even if advised of the possibility of such damage._ | |||
|
|
|||
| Licenses for all other components used can be found in the file [Additional Licenses](https://github.com/solidusio/solidus/blob/Fix-License-Issues/additionallicenses.md). | |||
There was a problem hiding this comment.
Can we use a relative link in markdown?
Suggested change
| Licenses for all other components used can be found in the file [Additional Licenses](https://github.com/solidusio/solidus/blob/Fix-License-Issues/additionallicenses.md). | |
| Licenses for all other components used can be found in the file [Additional Licenses](additionallicenses.md). |
There was a problem hiding this comment.
Honestly I was not aware that git supports relative paths!
Yes, makes sense and is absolutely indicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to previous conversations in PR #5948.
Copyright lists alphabetically the major contributors, points for generic contributions to the git commit list.
Some open issues:
Fixes #5947
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: