Enable ActiveStorage specs against Rails 6.1 #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/activestorage-specs
branch
from
ff0d6f4 to
480fc71
Compare
This template is used by both.
elia
force-pushed
the
kennyadsl/activestorage-specs
branch
3 times, most recently
from
573d627 to
430e14b
Compare
|
@elia can you please elaborate a little bit about why we are using the paperclip partial for ActiveStorage as well? |
|
@elia I did check the code and I think I've got it. We are now using the |
jarednorman
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is only useful to highlight the specs failures we have enabling ActiveStorage on Rails 6.1 and should be merged only after we fixed the existing issues.
Some ActiveStorage internals changed since we worked on this (see #2974 #3501) and we have to make some changes to reflect the new API.