Attachment adapters #3237
Merged
Attachment adapters #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's good practice not to define methods on Object, even if the method name was unique enough not to be in conflict with anything. Also changed the constant to reflect the actual content (Rails 5.2+) rather than a consequence of it, that allowed reusing it in more places.
elia
force-pushed
the
elia/attachment-adapters
branch
from
d5b7604 to
d387a72
Compare
spaghetticode
requested changes
Jun 23, 2019
There was a problem hiding this comment.
@elia I think this is a great improvement, thank you!
I left one comment, it is blocking as I think there's a bug.
Also, I am thinking about whether it may be worth documenting the ability to change the image uploads gem within the guides, as this feature may have a strong appeal to many devs, what do you think?
Again, thank you for your continuous work in trying to improve Solidus image uploads 🖼
|
I've tested this PR in a clean application that also has a custom definition of # config/initializers/spree.rb
Spree::Image.attachment_definitions[:attachment][:styles] = {
mini: '48x48>',
small: '100x100>',
product: '240x240>',
large: '600x600>',
mobile: '400x500>',
}Everything works as expected but we need to fix what @spaghetticode spotted, thanks @elia ! |
kennyadsl
force-pushed
the
elia/attachment-adapters
branch
from
d387a72 to
7205f46
Compare
kennyadsl
approved these changes
Jun 25, 2019
spaghetticode
approved these changes
Jun 25, 2019
jacobherrington
approved these changes
Jun 25, 2019
We keep Paperclip as the default strategy for new apps.
kennyadsl
force-pushed
the
elia/attachment-adapters
branch
from
7205f46 to
55abebe
Compare
4 tasks
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has been extracted from #2974 as suggested by @kennyadsl
Paperclip has been officially deprecated and is no more maintained, but the supposed replacement with ActiveStorage is not possible to due to lack of proper support for public long-term urls.
This PR allows Image and Taxon to switch their attachment implementation, extracting Paperclip to a concern, and opening the door for alternative implementations (e.g. Carrierwave, Shrine, AttachmentFu, et cetera).
Checklist: