Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap OrderUpdater#update in a transaction #1569

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Wrap OrderUpdater#update in a transaction #1569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions core/app/models/spree/order_updater.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,17 @@ def initialize(order)
# object with callbacks (otherwise you will end up in an infinite recursion as the
# associations try to save and then in turn try to call +update!+ again.)
def update
update_item_count
update_totals
if order.completed?
update_payment_state
update_shipments
update_shipment_state
@order.transaction do
update_item_count
update_totals
if order.completed?
update_payment_state
update_shipments
update_shipment_state
end
run_hooks
persist_totals
end
run_hooks
persist_totals
end

def run_hooks
Expand Down