Prototypes move to extension #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
reviewed
Oct 12, 2016
| @@ -94,8 +91,6 @@ def find_or_build_master | |||
| validates :shipping_category_id, presence: true | |||
| validates :slug, length: { minimum: 3 }, uniqueness: { allow_blank: true } | |||
|
|
|||
| attr_accessor :option_values_hash | |||
There was a problem hiding this comment.
I don't think this should be removed, it's a parameter accepted through the API.
gevann
force-pushed
the
prototypes-move-to-extension
branch
2 times, most recently
from
94af729
to
93486c7
Compare
jhawthorn
suggested changes
Oct 13, 2016
| @@ -74,9 +74,6 @@ def find_or_build_master | |||
|
|
|||
| has_many :variant_images, -> { order(:position) }, source: :images, through: :variants_including_master | |||
|
|
|||
| after_create :add_associations_from_prototype | |||
| after_create :build_variants_from_option_values_hash, if: :option_values_hash | |||
There was a problem hiding this comment.
We need to keep this as we ll since we are keeping option_values_hash
| # option_values_hash. | ||
| # | ||
| # @return [Array] the option_values | ||
| def ensure_option_types_exist_for_values_hash |
| @@ -310,21 +276,6 @@ def any_variants_not_track_inventory? | |||
| end | |||
| end | |||
|
|
|||
| # Builds variants from a hash of option types & values | |||
| def build_variants_from_option_values_hash | |||
|
Added some comments on the extension: solidusio-contrib/solidus_prototypes@9c36e3e#commitcomment-19425150 |
added 25 commits
October 14, 2016 10:18
Previously, @prototype was conditionally (if the corresponding ID as included in the params) in a before create callback on the product. This functionality has be moved out into a Prototypes extension.
added 7 commits
October 14, 2016 10:18
gevann
force-pushed
the
prototypes-move-to-extension
branch
from
93486c7
to
4ffd596
Compare
|
@jhawthorn I've made those requested changes. @tvdeyen Implemented your suggestions on the extension. Thanks for the feedback, you two! |
cbrunsdon
approved these changes
Oct 14, 2016
jhawthorn
approved these changes
Oct 17, 2016
|
Thanks @gevann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes prototypes from Solidus. The prototype functionality can be added back in to solidus with the
solidus_prototypeextension. Fixes issue #1481