Remove deprecated code #1461
Merged
Remove deprecated code #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the deprecation warning we said we'd remove this in Solidus 2.0.
jhawthorn
approved these changes
Sep 21, 2016
Senjai
approved these changes
Sep 21, 2016
|
@jhawthorn I've added a changelog entry and a "Removals" section. Look ok? |
mamhoff
approved these changes
Sep 22, 2016
|
Went ahead and merged since I started using the "Removals" section in other PRs as well. I'm happy to see that changed if we want different formatting or whatever though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the deprecation warning we said we'd remove this in Solidus 2.0.
If instead we don't actually want to remove this yet, we should probably update the deprecation message.