Remove solidus deprecations #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetticode
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Looks good to me, thank you @kennyadsl 👍
I have one question about having the I18n namespace in the views, then I noticed that commit 0293d9f includes a suggestion for a future possible improvement, what about creating an issue, so we don't lose track of it?
| @@ -1,10 +1,10 @@ | |||
| <!-- insert_bottom '[data-hook="localization_settings_body"]' --> | |||
| <div class="form-group"> | |||
| <label for="supported_locales_"> | |||
| <%= Spree.t(:'i18n.supported_locales') %> | |||
| <%= I18n.t(:'spree.i18n.supported_locales') %> | |||
There was a problem hiding this comment.
What about using ActionView::Helpers::TranslationHelper#t by dropping the I18n namespace in the ERB view code?
|
Issue opened: #121, thanks for your suggestion. Also, I think you are right about changing |
This option has been deprecated and will be removed in future versions of Solidus.
In favor of a standard link_to helper.
It changed some time and changes have not been reflected here causing visual issues.
Which is now deprecated. It has been replaced by setting the preference directly on the configuration. Sometimes stubbing is not the right thing to do, especially in specs that are testing preferences modification.
This removes the deprecation warning we were having calling Spree::Product#destroy in specs. Once it has been converted in Spree::Product#discard, the callbacks are no longer executed by default on translations and we needed to call discard_all explicitely. This commit also adds discard support to product translations
This is the only model (with Spree::Product) that has paranoia/discard enabled. This commit does not change the behavior but adds some specs to describe what's the expected one: when a shipping method is soft-deleted, translations are kept. A future improvement could be adding the deleted_at column to that translation table (as it's done with produts) and adding discard to that model in order to mark as discarded the translations associated to a discared shipping method.
It can lead to false positive.
kennyadsl
force-pushed
the
kennyadsl/remove-deprecations
branch
from
87799e4
to
fb89fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the deprecation warning currently present when running specs against solidus master. There's a commit for each warning, so it will be easier to read and review.