Implement Google merchant generator #6
Conversation
elia
force-pushed
the
g-merchant-generator
branch
from
b10e48c
to
527fce7
Compare
elia
force-pushed
the
g-merchant-generator
branch
2 times, most recently
from
4ca6bf2
to
e7ea0d5
Compare
There was a problem hiding this comment.
@aldesantis the idea behind not caring too much about making the google_merchant product feed extendability is that letting individual stores inherit from it is not ideal, especially since this is a concrete class, and I'm sure will face significant changes before we're done. That's why all the methods you mentioned are private.
We'd rather prefer it to be copied verbatim and modified, and given how short it is it should be pretty straightforward.
I'm not against a helper class that can collect useful code for building a google merchant feed generator, but would be better to source it from at least a couple of concrete classes.
elia
force-pushed
the
g-merchant-generator
branch
3 times, most recently
from
9fdd51e
to
e61799b
Compare
elia
force-pushed
the
g-merchant-generator
branch
from
e61799b
to
2a19661
Compare
| xml.title 'store title' | ||
| xml.link 'store link' | ||
| xml.description 'store description' | ||
| xml.language 'store lang' |
There was a problem hiding this comment.
I think we should try to provide some sensible defaults here. Ideally, I'd like each feed to be usable at a basic level without the need for customization.
For example, can we pass these as options as we do in solidus_product_feed?
Let me know if you disagree for some reason.
There was a problem hiding this comment.
In the latest commit I should have addressed these concerns 😃
nirebu
force-pushed
the
g-merchant-generator
branch
2 times, most recently
from
8c51458
to
a6e932a
Compare
nirebu
force-pushed
the
g-merchant-generator
branch
6 times, most recently
from
145f7e2
to
4f2ce1f
Compare
As specified in https://support.google.com/merchants/answer/7052112. This also adds global configuration attributes to be used in the store feed. Co-Authored-By: Flavio Auciello <[email protected]> Co-Authored-By: Elia Schito <[email protected]>
nirebu
force-pushed
the
g-merchant-generator
branch
from
4f2ce1f
to
831b179
Compare
Ref #4
This PR implements a generator for a Google Merchant XML feed. This rendered useful adding some global configuration attributes based on the Store information.