Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparations for first release #20

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Preparations for first release #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfd7cbe
Set correct copyright owner and GH organization
nirebu Jan 22, 2021
e31a0d4
Update extension to use solidus_dev_support 2.3
nirebu Jan 22, 2021
f297912
Fix linting issues
nirebu Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2020 [name of plugin creator]
Copyright (c) 2021 Nebulab SRLs
All rights reserved.

Redistribution and use in source and binary forms, with or without modification,
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Solidus Feeds

[![CircleCI](https://circleci.com/gh/nebulab/solidus_feeds.svg?style=shield)](https://circleci.com/gh/nebulab/solidus_feeds)
[![codecov](https://codecov.io/gh/nebulab/solidus_feeds/branch/master/graph/badge.svg)](https://codecov.io/gh/nebulab/solidus_feeds)
[![CircleCI](https://circleci.com/gh/solidusio-contrib/solidus_feeds.svg?style=shield)](https://circleci.com/gh/solidusio-contrib/solidus_feeds)
[![codecov](https://codecov.io/gh/solidusio-contrib/solidus_feeds/branch/master/graph/badge.svg)](https://codecov.io/gh/solidusio-contrib/solidus_feeds)

<!-- Explain what your extension does. -->
A framework for producing and publishing feeds on Solidus.
Expand Down Expand Up @@ -243,4 +243,4 @@ Please refer to the dedicated [page](https://github.com/solidusio/solidus/wiki/H

## License

Copyright (c) 2020 [name of extension author], released under the New BSD License.
Copyright (c) 2021 Nebulab SRLs, released under the New BSD License.
6 changes: 2 additions & 4 deletions lib/solidus_feeds/publishers/static_file.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@ def initialize(path:)
@path = path
end

def call
File.open(path, 'w') do |file|
yield file
end
def call(&block)
File.open(path, 'w', &block)
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion solidus_feeds.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ Gem::Specification.new do |spec|
spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 3']
spec.add_dependency 'solidus_support', '~> 0.5'

spec.add_development_dependency 'solidus_dev_support', '~> 2.1'
spec.add_development_dependency 'solidus_dev_support', '~> 2.3'
end
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
Dir["#{__dir__}/support/**/*.rb"].sort.each { |f| require f }

# Requires factories defined in lib/solidus_feeds/testing_support/factories.rb
require 'solidus_feeds/testing_support/factories'
SolidusDevSupport::TestingSupport::Factories.load_for(SolidusFeeds::Engine)

RSpec.configure do |config|
config.infer_spec_type_from_file_location!
Expand Down