Improved wrapped type definitions (support for Date and functions) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this. We may have clean type defs one day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Wrapped<T>type definition is still missing a few pieces to fully work in general. I first noticed this when working withDate, which always required manual casts because of theSymbol.toPrimitivesymbol. I had to ask for help in order to come up with a solution. To make other well-known symbols work, we could either add more explicitly forwarded definitions, or wait until the upstream TS issue gets a release (had recent activity, so may be available soon).I also may have to refine the forwarding of
AddCallable, but if you don't mind I'd first experiment with this change for a while and make necessary improvements step-by-step.