feat: createMutable support for class inheritance #2405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
createMutable
on a class which extends another class, reading from a getter of the parent class does not signal the subscribers. This is because for classes only the properties of the object's immediate prototype were being handled, not the entire (potential) chain of prototypes.How did you test this change?
Added a test and I tested it in my app where I've stumbled upon the issue where I could confirm that it works.