Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: createMutable support for class inheritance #2405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ddomonkos
Copy link

Summary

When using createMutable on a class which extends another class, reading from a getter of the parent class does not signal the subscribers. This is because for classes only the properties of the object's immediate prototype were being handled, not the entire (potential) chain of prototypes.

How did you test this change?

Added a test and I tested it in my app where I've stumbled upon the issue where I could confirm that it works.

Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: db47618

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant