Remove Props helper and shallow Readonly for props

solidjs · Mar 7, 2022 · 7447ce5 · 7447ce5
1 parent 64d8af1
commit 7447ce5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/solid/src/render/component.ts b/packages/solid/src/render/component.ts
@@ -15,10 +15,8 @@ export function enableHydration() {
   hydrationEnabled = true;
 }
 
-export type Props<P = {}> = Readonly<P>;
-export type PropsWithChildren<P = {}, C = JSX.Element> =
-  Props<P> & { readonly children?: C };
-export type Component<P = {}> = (props: Props<P>) => JSX.Element;
+export type PropsWithChildren<P = {}, C = JSX.Element> = P & { children?: C };
+export type Component<P = {}> = (props: P) => JSX.Element;
 export type ComponentWithChildren<P = {}, C = JSX.Element> =
   (props: PropsWithChildren<P, C>) => JSX.Element;
 /**
@@ -34,9 +32,9 @@ export type ComponentProps<T extends keyof JSX.IntrinsicElements | Component<any
     : T extends keyof JSX.IntrinsicElements
     ? JSX.IntrinsicElements[T]
     : {};
-/** Type of `props.ref`, for use in `Props`.
+/** Type of `props.ref`, for use in `Component` or `props` typing.
  *
- * @example Props<{ref: Ref<Element>}>
+ * @example Component<{ref: Ref<Element>}>
  */
 export type Ref<T> = T | ((val: T) => void);
 

diff --git a/packages/solid/web/test/suspense.spec.tsx b/packages/solid/web/test/suspense.spec.tsx
@@ -13,7 +13,7 @@ describe("Testing Suspense", () => {
     resolvers: Function[] = [],
     [triggered, trigger] = createSignal(false);
   const LazyComponent = lazy<typeof ChildComponent>(() => new Promise(r => resolvers.push(r))),
-    ChildComponent = (props: Props<{ greeting: string }>) => {
+    ChildComponent = (props: { greeting: string }) => {
       const [value] = createResource<string, string>(
         () => triggered() && "child",
         () => new Promise(r => setTimeout(() => r("Jo"), 300)),