Fix reload pragma for Vite #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22 (the comment, not the thread, since the thread is long fixed).
At some point between Vite 3 and Vite 5, Vite changed their way of checking whether a module should receive the HMR context or not. Previously, they required having the
import.meta.hot.accept()call to notify the import analysis that module is going to self-accept.Currently, they only check for the
import.meta.hotexpression, but that broke the HMR for Vite such that it's mergingimport.meta.hot.acceptcalls, leading to conflicts like declining HMR updates.The fix here is to remove the unnecessary
import.meta.hot.acceptcall.