Merge pull request #53 from solidjs/fix-granular

Fix granular mode
solidjs · Jan 19, 2024 · e1608f5 · e1608f5
2 parents 6d48742 + 290ac72
commit e1608f5
Show file tree

Hide file tree

Showing 52 changed files with 37,036 additions and 28,616 deletions.
diff --git a/src/babel/index.ts b/src/babel/index.ts
@@ -229,7 +229,9 @@ function getBindings(path: babel.NodePath): t.Identifier[] {
     ReferencedIdentifier(p) {
       // Check identifiers that aren't in a TS expression
       if (!isInTypescript(p) && isForeignBinding(path, p, p.node.name)) {
-        identifiers.add(p.node.name);
+        if (p.isIdentifier() || p.parentPath.isJSXMemberExpression()) {
+          identifiers.add(p.node.name);
+        }
       }
     },
   });

diff --git a/tests/__snapshots__/esm.test.ts.snap b/tests/__snapshots__/esm.test.ts.snap
diff --git a/tests/__snapshots__/rspack-esm.test.ts.snap b/tests/__snapshots__/rspack-esm.test.ts.snap
diff --git a/tests/__snapshots__/standard.test.ts.snap b/tests/__snapshots__/standard.test.ts.snap