Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies #91

Merged
merged 10 commits into from
Aug 21, 2023
Merged

Updating dependencies #91

merged 10 commits into from
Aug 21, 2023

Conversation

Janther
Copy link
Collaborator

@Janther Janther commented Aug 17, 2023

Since we had a few critical dependencies I updated all of the dependencies that didn't affect directly the build process.

  • Using latest types and typescript
  • Latest testing framework
  • Latest linters

The last version of prettier enforced a few changes in the files.

The last typescript and linters uncovered a few type errors that I fixed and will document in comments on this PR.

Once #90 is merged, you can see that testing and linting is working properly.

sadly the latest versions of esbuild increase the compiled file by a large amount.
Latest versions of antlr4 create an error in the integration tests.

test/index.ts Show resolved Hide resolved
test/index.ts Show resolved Hide resolved
src/tokens.ts Show resolved Hide resolved
src/parser.ts Show resolved Hide resolved
src/parser.ts Show resolved Hide resolved
src/parser.ts Outdated Show resolved Hide resolved
src/ASTBuilder.ts Outdated Show resolved Hide resolved
src/ASTBuilder.ts Outdated Show resolved Hide resolved
src/ASTBuilder.ts Outdated Show resolved Hide resolved
src/ASTBuilder.ts Outdated Show resolved Hide resolved
@Janther
Copy link
Collaborator Author

Janther commented Aug 17, 2023

I detailed all changes I actively made to pass the linter errors.

./parser/src/ASTBuilder.ts
  1390:35  error  Unsafe argument of type `any` assigned to a parameter of type `ParserRuleContext | ParseTree`  @typescript-eslint/no-unsafe-argument
  1594:31  error  Unsafe argument of type `any` assigned to a parameter of type `ParseTree`                      @typescript-eslint/no-unsafe-argument
  1597:29  error  Unsafe argument of type `any` assigned to a parameter of type `ParserRuleContext | ParseTree`  @typescript-eslint/no-unsafe-argument
  1619:71  error  Unsafe argument of type `any` assigned to a parameter of type `ParameterContext`               @typescript-eslint/no-unsafe-argument

./parser/src/parser.ts
  101:34  error  Unsafe argument of type `any` assigned to a parameter of type `"SourceUnit" | "PragmaDirective" | "ImportDirective" | "ContractDefinition" | "InheritanceSpecifier" | "StateVariableDeclaration" | "UsingForDeclaration" | "StructDefinition" | ... 63 more ... | "TypeDefinition"`  @typescript-eslint/no-unsafe-argument
  118:32  error  Unsafe argument of type `any` assigned to a parameter of type `never`                                                                                                                                                                                                                @typescript-eslint/no-unsafe-argument
  133:24  error  Unsafe argument of type `any` assigned to a parameter of type `never`                                                                                                                                                                                                                @typescript-eslint/no-unsafe-argument

./parser/src/tokens.ts
  76:31  error  Unsafe argument of type `any` assigned to a parameter of type `string`  @typescript-eslint/no-unsafe-argument

./parser/test/index.ts
  24:20  error  Unsafe argument of type `any` assigned to a parameter of type `number`  @typescript-eslint/no-unsafe-argument

The rest was Prettiers doing.

@fvictorio
Copy link
Contributor

Thanks a lot for this @Janther! I pushed some extra commits but I think they are uncontroversial (let me know if you disagree).

@fvictorio fvictorio merged commit a3228b5 into master Aug 21, 2023
@fvictorio fvictorio deleted the updating-dependencies branch August 21, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants